-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Update result for test_data_quality_plugin #3390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3390 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 128 128
Lines 19843 19843
=======================================
+ Hits 17387 17388 +1
+ Misses 2456 2455 -1 ☔ View full report in Codecov by Sentry. |
devdeps job failure is unrelated. Note that remote data job now passes with this patch. |
let's merge this for now and follow-up with @bmorris3 if any other changes are needed |
Follow up at 🐱. |
…0-on-v4.1.x Backport PR #3390 on branch v4.1.x (TST: Update result for test_data_quality_plugin)
Description
The data label has changed from
(DQ: 1)
to(DQ: 3)
. Since I don't have an older copy of the MAST image that @bmorris3 used to make that test, I am not sure why. The new label seems in line with existing parser logic in that it uses EXTNUM instead of EXTVER to make the label, so not sure why it was 1 before.Goal is to fix the test so it does not block unrelated PRs. I am not sure if you want me to refactor the DQ parser.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.